Skip to content

[No QA] Docs updates for E/A#98666 Rillet Consolidated Travel Billing settlement setting - #98929

Merged
blimpich merged 1 commit into
mainfrom
melvin-docs-rillet-consolidated-travel-billing
Aug 19, 2026
Merged

blimpich merged 1 commit into
mainfrom
melvin-docs-rillet-consolidated-travel-billing

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Follow-up to #98666, which renamed the Rillet settlement label from "Travel Invoicing" to Consolidated Travel Billing so it matches the wording used everywhere else in the app (e.g. NetSuite).

The Rillet help article (Configure-Rillet.md) listed the advanced settlement automation toggles but only documented Sync Expensify Card settlements — it never mentioned the Consolidated Travel Billing settlement setting. This PR brings the doc in line with the current UI:

  • Adds a Sync Consolidated Travel Billing settlements bullet to the "How to configure Rillet advanced settings" list.
  • Updates the "Do I need a bill payment or settlements account?" FAQ to note that a settlements account is also required when that setting is enabled.

Labels are taken verbatim from the merged en.ts copy (Sync Consolidated Travel Billing settlements), which is the exact string rendered in the UI.

Related Issues

Follow-up docs for #98666 (partially addresses Expensify/Expensify#653012).

Screenshots/Videos

N/A — help site copy only.


@blimpich, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

…nfig

Co-authored-by: Benjamin Limpich <blimpich@users.noreply.github.com>
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Aug 18, 2026
@blimpich
blimpich marked this pull request as ready for review August 19, 2026 17:25
@blimpich
blimpich requested a review from rlinoz August 19, 2026 17:25
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment
This PR makes a small, focused documentation update to docs/articles/Unlisted/Configure-Rillet.md, bringing it in line with the current UI following Expensify/App PR 98666. It adds a Sync Consolidated Travel Billing settlements bullet to the "How to configure Rillet advanced settings" list and updates the "Do I need a bill payment or settlements account?" FAQ answer to reference the new toggle. The changes are accurate, consistent with the existing article, and use the exact UI string from en.ts.

Scores Summary

  • Readability: 9/10 - The new bullet mirrors the existing settlement-toggle format precisely (bold label, en dash, concise action-oriented description). The FAQ update reads cleanly and the added condition parses naturally.
  • AI Readiness: 9/10 - Uses the full, UI-exact feature name (Sync Consolidated Travel Billing settlements) consistently in both the settings list and the FAQ, which strengthens semantic retrieval. Additions sit under existing task-based sub-headings and preserve the single-title / FAQ structure. No metadata changes were needed for these additions.
  • Style Compliance: 10/10 - Toggle label is bolded and matches the UI string verbatim per the Section and Toggle References rules in HELPSITE_NAMING_CONVENTIONS.md. No quotation marks, no paraphrasing, no synonyms. Terminology and formatting are fully consistent with the surrounding content.

Key Findings

  • Toggle label taken verbatim from the merged en.ts copy, satisfying the exact-UI-terminology requirement.
  • New bullet is stylistically identical to the adjacent Sync Expensify Card settlements entry, keeping the list consistent and scannable.
  • FAQ answer correctly extends the existing sentence rather than restructuring it, preserving the established FAQ format.
  • No governance violations detected within the diff; changes touch only added/modified lines and do not disturb the heading hierarchy or metadata.

Recommendations

  • No changes required. The PR is accurate and compliant.
  • Optional (out of scope for this PR): the FAQ answer now chains two long conditions in one sentence; if a future edit touches this area, consider splitting into two sentences for slightly easier scanning.

Files Reviewed

  • docs/articles/Unlisted/Configure-Rillet.md - Approved. Adds one settings bullet and updates one FAQ answer; both fully compliant with governance.

Note: This review is based solely on the proposed diff. No inline comments were necessary given the small, compliant scope.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c4b582c925

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@blimpich
blimpich merged commit 3dc2897 into main Aug 19, 2026
20 of 22 checks passed
@blimpich
blimpich deleted the melvin-docs-rillet-consolidated-travel-billing branch August 19, 2026 22:41
@OSBotify OSBotify mentioned this pull request Aug 20, 2026
61 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/blimpich in version: 9.4.57-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@izarutskaya

Copy link
Copy Markdown

@blimpich Probably no QA needed, ok to checkoff the list?

@rlinoz

rlinoz commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Yes please @izarutskaya !

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 9.4.57-3 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@stephanieelliott stephanieelliott changed the title Docs updates for E/A#98666 Rillet Consolidated Travel Billing settlement setting [No QA] Docs updates for E/A#98666 Rillet Consolidated Travel Billing settlement setting Sep 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants